🌱 Add check for client in e2e #1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
=======================================
Coverage 74.68% 74.68%
=======================================
Files 42 42
Lines 3271 3271
=======================================
Hits 2443 2443
Misses 652 652
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Depending on how e2e is run, we may not have a k8s client available. Signed-off-by: Todd Short <[email protected]>
tmshort
force-pushed
the
skip-metrics
branch
from
c89fae9 to
854432d
Compare
camilamacedo86
approved these changes
Dec 17, 2024
|
Ok, I'll make a corresponding change to catalogd. |
|
See operator-framework/catalogd#485 @camilamacedo86 for the catalogd version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on how e2e is run, we may not have a k8s client available.
Description
Reviewer Checklist